OpenSIPS / opensips

OpenSIPS is a GPL implementation of a multi-functionality SIP Server that targets to deliver a high-level technical solution (performance, security and quality) to be used in professional SIP server platforms.
https://opensips.org
Other
1.22k stars 567 forks source link

[BUG] B2BUA does not add < > brackets in generated To-Headers for reponses (for requests this was fixed, cf. issue 2843) #3419

Open bhoeneis opened 1 week ago

bhoeneis commented 1 week ago

Summary Bug Description

The bug described in https://github.com/OpenSIPS/opensips/issues/2843 has not been fixed for replies. I run into a case with a 407 reply (to an INVITE request, via B2BUA), where he SIP-URI of the To Header Field is still not enclosed in angle brackets (<....>) as in the following example (A calls B via a B2BUA):

Reproduce Behavior:

Expected behavior

Observed behavior

Relevant System Logs

N/A

OS/environment information

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 24.04 LTS
Release:    24.04
Codename:   noble

$ uname -a
Linux imp-test 6.8.0-35-generic #35-Ubuntu SMP PREEMPT_DYNAMIC Mon May 20 15:51:52 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

$ opensips -V
version: opensips 3.4.5 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, HP_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 099e771b3
main.c compiled on  with gcc 13

Additional context

Note that this bug appears to have been fixed only for requests, but not replies

bogdan-iancu commented 2 days ago

could you post (or PM me) a sip capture showing all the SIP req/rpl getting in and out of OpenSIPS B2B? I'm asking as the B2B entities module is sending the replies (back to UAC) into a transactional way, by using TM (which uses the transaction of the originally received INVITE)