search

OpenSLO / slogen

tool to create and manage content for reliability tracking from logs/event data.
Apache License 2.0
79 stars 6 forks source link

The "Overview Dashboard" terraform code isn't static #44

Closed lswith closed 2 years ago

lswith commented 2 years ago

The "tf/dashboards/overview-.tf" file is constantly changing, each time I run "slogen . --apply --clean".

I believe this is because the map is unordered and the rows are being pulled out arbitrarily: https://github.com/SumoLogic-Labs/slogen/blob/main/libs/overview.go#L193

This means that my terraform code changes on each run, rather than being hermetic.

This is a low priority, but it would be nice to have these rows sorted.

agaurav commented 2 years ago

Agreed, all the need loops in templates should be sorted by the resource name. should be an easy change.

agaurav commented 2 years ago

fixed in https://github.com/SumoLogic-Labs/slogen/pull/51/commits/9cc3f5932c277d26bbd5a5236263d4a638c2049d