search

OpenSMFS / FRETBursts

Burst analysis software for single and multi-spot single-molecule FRET (smFRET) data.
https://opensmfs.github.io/FRETBursts/
GNU General Public License v2.0
12 stars 9 forks source link

mpl.normpdf removed in Matplotlib 3.1 #30

Open BenjaminAmbrose opened 4 years ago

BenjaminAmbrose commented 4 years ago

I recently had to do a fresh install of anaconda, and now importing fretbursts returns an import error for normpdf. I've checked and it's been removed in 3.1, I reverted back to matplotlib 3.0.3 and the error went away.

It's not a huge issue for now but I just thought I should let you know.

tritemio commented 4 years ago

Thanks for the report.

@BenjaminAmbrose, would you mind sending a PR? You can simply define the same normpdf function in utils.py and use that instead. A unit test testing against scipy.stats.norm.pdf would be great.

tritemio commented 4 years ago

To be clear, I have no more time to maintain FREBursts. I may do one last release, possibly with this PR included and I am happy to hand the management of the repo to whoever is interested.

Would be nice that some FRETBursts users would pick up the open source maintaince task instead of fixing or modifying it privately.

BenjaminAmbrose commented 4 years ago

I'm happy to take a stab at this fix at some point but I don't have time to figure it out right now, I'll let you know how I get on

On Thu, 24 Oct 2019 at 12:59, Antonino Ingargiola notifications@github.com wrote:

To be clear, I have no more time to maintain FREBursts. I may do one last release, possibly with this PR included and I am happy to hand the management of the repo to whoever is interested.

Would be nice that some FRETBursts users would pick up the open source maintaince task instead of fixing or modifying it privately.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenSMFS/FRETBursts/issues/30?email_source=notifications&email_token=AI24HXV3DKKBCQNFILKOHJDQQGEYVA5CNFSM4JDOLF42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEYRHA#issuecomment-545884316, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI24HXVBZIRVX23JJYNJAHTQQGEYVANCNFSM4JDOLF4Q .