search

OpenSMFS / FRETBursts

Burst analysis software for single and multi-spot single-molecule FRET (smFRET) data.
https://opensmfs.github.io/FRETBursts/
GNU General Public License v2.0
12 stars 9 forks source link

New version compatibility #37

Closed harripd closed 1 year ago

harripd commented 1 year ago

I've gone through the various issues, and tried to update everything that is/was practical.

  1. Replaced the matplotlib normdf with scipy.stats.norm.pdf as in #33
    • Added test to confirm new function gives normal behavior (not sure this is really necessary, as this is not a test of FRETBursts, but rather a test of scipy)
  2. Removed python 2.0 leftovers
  3. Replaced np.sum with sum because of deprecation warnings as per #35

Hopefully others can review and if everything works (I've run all tests on my computer, but the travis/apveyor are still beyond my purview), we can push up to pip/conda-forge so that people installing FRETBursts won't have issues for people installing.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB