OpenSPP / openspp-modules

OpenSPP Odoo modules
https://openspp.org
GNU Lesser General Public License v3.0
26 stars 11 forks source link

Split the UI and the demo generator of farmer registry demo module #567

Closed reichie020212 closed 1 month ago

reichie020212 commented 2 months ago

Currently there is no general module for farmer registry base that can be used in production generally, to accomodate this, let's do the following

anthonymarkQA commented 1 month ago

Findings: Returned to dev

Issues Found: Installing the new module: OpenSPP Farmer Registry Default UI seems to not install the farmer specific tabs for the group. image

Installing farmer registry Demo should ONLY add the Generate sample data from configuration and nothing else- Fail (it also adds the farmer registry default Ui like the tabs for the farmer etc..) image

icon of OpenSPP Farmer Registry Default UI is broken image

anthonymarkQA commented 1 month ago

Hi @celinenilla , as @reichie020212 investigated this ticket and concluded thatFarmer_registry_demomodule comes with additional tabs for the farm group, these additional tabs were created under farmer_registry_demo intended to show specific clients what farmer registry could offer more than just the default tabs it has. thats why installing it adds not just the generate sample data button but also additional tabs for the farmer.

to achieve your goal that only generate sample data button will be added when installing "farmer_registry_demo" we can request red to comment out the additional tabs in the farmer_registry_demo module's codes to hide them(additional tabs) for now.

this would also mean i will update the testcases as i am under the assumption that these additional tabs come as default for farmer registry offering.

let us know what you think

Image

celinenilla commented 1 month ago

sounds good, the default ui can do without these three tabs. let's also hide them in the demo module.

anthonymarkQA commented 1 month ago

Findings: QA Passed

Fix farmer registry base default UI app icon - pass image

Add necessary farmer tabs in groups when installing spp_farmer_registry_base where this automatically installs OpenSPP Farmer Registry Default UI - pass image

Installing farmer registry demo module should only add generate sample data button - fail(this should be worked on another ticket https://github.com/OpenSPP/openspp-modules/issues/606) as there are modules involved not mentioned in this ticket.