search

OpenST / brandedtoken-contracts

Token and related smart contracts for token economies
Apache License 2.0
17 stars 12 forks source link

Require BrandToken has same decimals as ValueToken #168

Closed benjaminbollen closed 5 years ago

benjaminbollen commented 5 years ago

The conversion rate assumes the value token and the brand token have the same decimals, but we don't explicitly require this in the constructor.

Note, eg. OST has decimals 18, USD coin 6, and gemini dollar 2; by requiring the decimals to match explicitly the conversion rate is more clear and cannot be misused to accommodate for different decimals between value token and Brand Token

schemar commented 5 years ago

Should we already start thinking about a basket of tokens with different numbers of decimals?

deepesh-kn commented 5 years ago

This is already implemented in https://github.com/OpenST/brandedtoken-contracts/issues/171 Closing this issue.