search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Don't expose EIP20Token in npm package #629

Closed hobofan closed 5 years ago

hobofan commented 5 years ago

The EIP20Token the is currently exposed in the NPM package is not what one would normally expect from an EIP20Token, where you can define the supply, etc., but it actually serves as a base contract that is inherited by OSTPrime.

This can be very confusing, as this can lead to the assumption that EIP20Token is a simple EIP20 token that can be used for the tokenAddress and baseTokenAddress params of Gateway. In fact EIP20Token has a fixed supply of 0 and is useless when deployed directly.

Because of this EIP20Token should be exposed as EIP20TokenInterface and should only include the ABI, not the BIN.

Please make sure the ABI is exactly what a consumer would expect.

hobofan commented 5 years ago

~Another fix for the npm package: OSTPrime should be exposed~ Done in #636

schemar commented 5 years ago

That's done in #636