search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Clean up #633

Closed schemar closed 5 years ago

schemar commented 5 years ago

Fixes #459 Fixes #555 Fixes #552 Fixes #632 Fixes #604 Fixes #551 Fixes #554

schemar commented 5 years ago

Nice cleanup 🦆 Most of the sections are done ✅ I have some feedbacks for two sections 👷

Moved shared files into lib 👷

1. EIP20TokenInterface should also move to lib.

2. `MockAnchor` should probably be in `test/anchor` instead of `test/core`, considering the consistency.

Renamed ...Mock to Mock... ✅ Moved all test doubles into test dir✅ Updated copyright to 2019✅ Deleted tools/compile.sh✅ Deleted unused files 👷

1. local-poa-geth.sh

2. Docs contain old contract docs(example OpenstUtility). are we going to update these docs and delete old?

3. test/data/AccountInfo

4. contract_structure_test.js

5. test/gateway/helpers/helper.js

Moved Anchor into anchor directory✅

Also one extra point:👷 RLPTest -> TestRLP

Thank you! I will get to it right away :) This morning under the shower I also realized that I forgot to move the Anchor test files into test/anchor ☝️

schemar commented 5 years ago

Moved shared files into lib 👷

1. EIP20TokenInterface should also move to lib.

✅ 

2. `MockAnchor` should probably be in `test/anchor` instead of `test/core`, considering the consistency.

✅

Deleted unused files 👷

1. local-poa-geth.sh

✅

2. Docs contain old contract docs(example OpenstUtility). are we going to update these docs and delete old?

✅ I deleted the docs. They seemed outdated.

3. test/data/AccountInfo

✅

4. contract_structure_test.js

✅

5. test/gateway/helpers/helper.js

✅

Also one extra point:👷 Rename RLPTest -> TestRLP

✅

Also moved anchor tests into anchor directory.