search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Rearrange deletion of structs in confirm revert stake intent and confirm revert redeem intent #663

Closed 0xsarvesh closed 5 years ago

0xsarvesh commented 5 years ago

Fixes #662 partially

In order to follow best practices, any state change like deletion should happen before any external call.

Though confirm revert stake intent and confirm revert redeem intent doesn't make any external call, its good practice to move state changeup in the method.