search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Remove beneficiary and amount validations. #667

Closed pgev closed 5 years ago

pgev commented 5 years ago

Remove beneficiary and amount validations from UtilityBrandedToken increaseSupply and decreaseSupply functions.

deepesh-kn commented 5 years ago

Nice 🙌 Two comments:

  1. Please remove amount greater than zero condition from increaseSupplyInternal in UtilityToken
        require(
            _amount > 0,
            "Amount should be greater than zero."
        );
  1. Please update the change log aswell.

LGTM, once this condition and its corresponding test is removed

benjaminbollen commented 5 years ago

duplicated in #673 😱

benjaminbollen commented 5 years ago

closing in favor of #673 in agreement with @pgev