search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

token should be called valueToken where applicable #701

Closed schemar closed 5 years ago

schemar commented 5 years ago

Use valueToken instead of token accross contracts (OSTPrime, UtilityToken, EIP20CoGateway, EIP20Gateway and SimpleStake).

Example: https://github.com/OpenSTFoundation/mosaic-contracts/blob/fa436b06cacf3ea84d72550b7398f94220476648/contracts/gateway/UtilityToken.sol#L79

benjaminbollen commented 5 years ago

does this break interfaces, or only improve the readability (by using consistent names)?

jasonklein commented 5 years ago

does this break interfaces, or only improve the readability (by using consistent names)?

(as discussed and agreed elsewhere) Yes, this does break interfaces (e.g., EIP20Gateway.token() --> EIP20Gateway.valueToken()); getters will be added to fix the breaks.