Gateways should store roots in ring buffer

deepesh-kn commented 5 years ago

Fixes: #698 Was potentially done in #669, but this required interface change and the variable index of message box would change.

This PR implements the logic without the interface change. This includes the library. We can evaluate on which logic should be adapted.

This PR includes the code change, unit tests for the library.

With Library approach, there is no interface change. No efforts for backward compatibility.
With the contract approach, the interface will change and the JS layer needs additional effort to provide backward compatibility.

If this approach is acceptable by all then I will add a few more test cases.

schemar commented 5 years ago

More persons should comment on this PR.

deepesh-kn commented 5 years ago

As per the discussion, it is decided to go with the contract approach. Closing this PR, the new PR is raised here https://github.com/OpenST/mosaic-contracts/pull/726

OpenST / mosaic-contracts