search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Staker proxy #745

Closed schemar closed 5 years ago

schemar commented 5 years ago

A new staker proxy contract to stake on the gateway.

Temporarily added a composer interface to be able to call removeStakerProxy. See also comment on https://github.com/OpenST/mosaic-contracts/issues/742.

Added unit tests for the proxy's methods. Added new test doubles to ease writing of unit tests.

Fixes #741

schemar commented 5 years ago

@deepesh-kn I added a gateway interface, please check. I will now start with the tests.

schemar commented 5 years ago

Ready for review

schemar commented 5 years ago

🎈bouncing due to failing tests

schemar commented 5 years ago

Back to 🔍Review, only a ganache hiccup.

abhayks1 commented 5 years ago

Reviewing...

schemar commented 5 years ago

On it 🚂

deepesh-kn commented 5 years ago

Reviewing 🦖

schemar commented 5 years ago

Ready for review again. _to can now be zero, _token cannot.

gulshanvasnani commented 5 years ago

@schemar , The logic which is used for implementing mutex already exists in Mutex contract under lib. I think we must use the contract.

schemar commented 5 years ago

@schemar , The logic which is used for implementing mutex already exists in Mutex contract under lib. I think we must use the contract.

Good catch, thanks 👍 Can you please create the appropriate ticket?