OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Generated proof data should retain its pattern #754

Closed schemar closed 5 years ago

schemar commented 5 years ago

Story

As a developer I want to know which pattern caused an MPP library test to fail Because it helps me debug the case

Scenario

Given that I run the MPP.verify unit tests When a test based on the data from the fuzzy proof generator fails Then the message should include the pattern Instead it currently only contains the arguments to verify

Info

TODO: When generating and storing the proof data with the fuzzy generator in ./tools/fuzzy_proof_generator_tool/generate.ts, also store the pattern that was used to generate the proof in the generated JSON file.

That should be all, as the assert message in ./test/lib/merkle_patricia_proof.js already contains data, which now contains the pattern.

ℹ️ This is a follow-up to #743 and #751