search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Update truffle dependency #759

Closed schemar closed 5 years ago

schemar commented 5 years ago

References https://github.com/OpenST/mosaic-contracts/issues/758

schemar commented 5 years ago

I restarted the failing tests, but it appears the updated truffle version may actually result in failing unit tests. Also running the tests locally now.

schemar commented 5 years ago

OK there are definitely problems with Truffle 5.0.19 in mosaic contracts.

schemar commented 5 years ago

It may be necessary to update the git submodules after upgrading the truffle versions there. Not sure. I get errors when I try to compile right now.

schemar commented 5 years ago

I think I ended up in git submodule hell :sweat_smile: contracts includes utiliytoken includes organization. I am not really able to compile any more. I hope this is something I messed up only locally for me ...

deepesh-kn commented 5 years ago

I think I ended up in git submodule hell 😅 contracts includes utiliytoken includes organization. I am not really able to compile any more. I hope this is something I messed up only locally for me ...

Fixed the issue. Now open for review.