search

OpenST / mosaic-contracts

Mosaic-0: Gateways and anchors on top of Ethereum to scale DApps
https://discuss.openst.org/c/mosaic
MIT License
114 stars 31 forks source link

Remove mutex from OSTComposer::revokeStakeRequest and OSTComposer::rejectStakeRequest #768

Closed pgev closed 5 years ago

pgev commented 5 years ago

We can safely remove mutex from OSTComposer::revokeStakeRequest and OSTComposer::rejectStakeRequest as the following statements in function OSTComposer::removeStakeRequest (called within above-mentioned functions) protects against reentrancy:

        delete stakeRequestHashes[staker][address(stakeRequest.gateway)];
        delete stakeRequests[_stakeRequestHash];
deepesh-kn commented 5 years ago

This will be handled in this ticket.https://github.com/openst/mosaic-contracts/issues/763