search

OpenST / openst-contracts

OpenST is a framework for building token economies on Ethereum
Apache License 2.0
26 stars 19 forks source link

Change sequence of hashing in EXECUTE_RULE_CALLPREFIX constant of tokenholder contract #179

Closed gulshanvasnani closed 5 years ago

gulshanvasnani commented 5 years ago

Currently the sequence of hashing of EXECUTE_RULE_CALLPREFIX is :- https://github.com/OpenST/openst-contracts/blob/develop/contracts/token/TokenHolder.sol#L100

But the hashing must be in the order of parameters of method executeRedemption. https://github.com/OpenST/openst-contracts/blob/develop/contracts/token/TokenHolder.sol#L380

So, the sequence of EXECUTE_REDEMPTION_CALLPREFIX constant must be :- bytes4 public constant EXECUTE_REDEMPTION_CALLPREFIX =bytes4(keccak256("executeRedemption(address,bytes,uint256,bytes32,bytes32,uint8)"));