search

OpenST / openst-contracts

OpenST is a framework for building token economies on Ethereum
Apache License 2.0
26 stars 19 forks source link

Add FirewalledRule #200

Closed schemar closed 5 years ago

schemar commented 5 years ago

I added a FirewalledRule which can be extended in order to restrict relaying of meta-transactions to organization workers. The rule that is to be restricted must extend the FirewalledRule and add the modifier firewalled to all relevant functions.

For testing I created two test contract files. One that uses the modifier, and one that calls the one that uses the modifier. Required in order to simulate rules calling on each other and checking for the relayer.

Added a step to manually install npx inside docker until the docker image is fixed. The problem is reported and confirmed at https://github.com/crytic/eth-security-toolbox/issues/8

Fixes #199

schemar commented 5 years ago

Crytic fixed the docker image, I should test and remove the extra line before merging!

schemar commented 5 years ago

When they fixed the previously reported bug, it seems they broke something else. I made a new report: https://github.com/crytic/eth-security-toolbox/issues/9

Waiting for an update, as this cannot be fixed with a workaround.

schemar commented 5 years ago

Travis CI cannot cache docker images (https://docs.travis-ci.com/user/caching/#things-not-to-cache):

Docker images are not cached, because we provision a brand new virtual machine for every build.

schemar commented 5 years ago

@pgev can you please have a look? I removed slither from make:all. I cannot get slither work with the eth-security-toolbox.