search

OpenSTEF / openstef-dbc

Provides (company specific) database connector for the OpenSTEF package
Mozilla Public License 2.0
1 stars 7 forks source link

Low level methods arguments in high level methods arguments #149

Open maxi-fort opened 1 month ago

maxi-fort commented 1 month ago

WHAT : Some high level methods do not allow specifying argument that low level methods allows. For example, country argument is absent whereas it could be specifyed and therefore settable :

https://github.com/OpenSTEF/openstef-dbc/blob/00f73180db8374ac33e2722daf94c1fa3bc27f4f/openstef_dbc/services/model_input.py#L77-L82

An other example with source :

https://github.com/OpenSTEF/openstef-dbc/blob/00f73180db8374ac33e2722daf94c1fa3bc27f4f/openstef_dbc/services/predictor.py#L73-L79

Therefore, source is forced to "optimum" when using ModelInput class

HOW : Add low level methods arguments in high level methods arguments

maxi-fort commented 1 month ago

New example, When using get_load_by_pid, if aggregated=True and ignore_factor=False, forecast_resolution is ignored and default value of 15min is used :

https://github.com/OpenSTEF/openstef-dbc/blob/00f73180db8374ac33e2722daf94c1fa3bc27f4f/openstef_dbc/services/ems.py#L210-L211