Closed TcT2k closed 5 years ago
Looking good! Thanks a lot for looking into it.
Here are my thoughts:
openswe1r
, packagename name should be something like OpenSWE1R-OpenSWE1R-<git-commit>
? To be honest, it has been a couple of months (/ years?) since I've worked on deployment, so I'm not even sure what our options are.OpenSWE1R-<git-commit>-x64-Windows-MSVC
and OpenSWE1R-<git-commit>-x64-Windows-MSYS
. This turns the last part into an optional variant. Linux and macOS would just be called OpenSWE1R-<git-commit>-x64-Linux
and OpenSWE1R-<git-commit>-x64-macOS
. You'll also notice that I split OS and architecture, because we'll eventually have other architectures probably. So we should be more explicit about it (architecture could also be moved to the end or something - I don't know).(Also consider joining our gitter.im channel)
I just merged this as-is. I had intended to do this months ago but got distracted with other projects. By now I've lost oversight - rather than delaying this further and causing more work, I think it's better to just accept this change. If there's anything broken or horrible it can be fixed iteratively.
Thanks for this large contribution!
Partly as general improvement but also specifically addressing issue #148
Open ToDos (some of which I need input on):
I'll create issues for a few open things after this is merged: