Cleaned build.cmd and removed hardcoded MSBuild path

OpenSalamander / salamander

Open Salamander

GNU General Public License v2.0

284 stars 40 forks source link

Cleaned build.cmd and removed hardcoded MSBuild path #48

Closed 0xeb closed 4 months ago

0xeb commented 4 months ago

@janrysavy @rysavyjan ping? couple lines PR, what's the hold up?

janrysavy commented 4 months ago

%MSB% is not defined:

build.cmd
C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\amd64\MSBuild.exe
C:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe
Building Debug/x64
'""' is not recognized as an internal or external command,
operable program or batch file.

Could you please also keep original functionality to run batch file directly when MSBuild.exe exist on predefined path?

0xeb commented 4 months ago

ok, fixed and added back hardcoded path (not a good professional practice though).