OpenSalamander / salamander

Open Salamander
GNU General Public License v2.0
284 stars 40 forks source link

TAR: added zstd and lzma support #5

Open lejcik opened 8 months ago

lejcik commented 8 months ago

Added support for opening .zstd and .xz files with TAR plugin.

manison commented 8 months ago

Wow, support for XZ compressed Debian packages has been high on my wish list. Thanks for this! 👍

elieux commented 8 months ago

Is this the update from here? :) https://forum.altap.cz/viewtopic.php?p=71603

lejcik commented 8 months ago

Is this the update from here? :) https://forum.altap.cz/viewtopic.php?p=71603

yes, it's exactly this one

janrysavy commented 7 months ago

When compiling x64 targets, I receive the following warning:

salamander\src\plugins\tar\tardll.cpp(183,17): warning C4477: '_snprintf_s' : format string '%.*s' requires an argument of type 'int', but variadic argument 2 has type 'size_t'
janrysavy commented 7 months ago

Shouldn't we have one common vcpkg_installed directory for the whole Salamader project? It is now located in src\plugins\tar\vcpkg_installed, which would mean that the Salamander core and each plugin would have its own version?

lejcik commented 7 months ago

When compiling x64 targets, I receive the following warning:

salamander\src\plugins\tar\tardll.cpp(183,17): warning C4477: '_snprintf_s' : format string '%.*s' requires an argument of type 'int', but variadic argument 2 has type 'size_t'

forgot to check also x64 compilation log, fixed,

lejcik commented 7 months ago

Shouldn't we have one common vcpkg_installed directory for the whole Salamader project? It is now located in src\plugins\tar\vcpkg_installed, which would mean that the Salamander core and each plugin would have its own version?

this is a question if this is possible, the vcpkg.json manifest file defines dependencies per project, so each subproject in a solution should have its own manifest file, and may require different versions of the same libraries,

so far I didn't find anything useful in the documentation how to do that, but at least I'd add this to the .gitignore file to ignore the vcpkg_installed temporary stuff:

# vcpkg
vcpkg_installed/