search

OpenScan-org / OpenScan2

an improved firmware for the OpenScan devices, featuring many more cameras and a greatly improved overall usability
GNU General Public License v3.0
254 stars 29 forks source link

Feature: aggregate all stacked photos on folders inside the zip #79

Closed stealthizer closed 3 months ago

stealthizer commented 11 months ago

What: The result of the scan session is a zip file and the contents are .jpg without any folder. When using focus stacking, that same pattern is followed. The software we usually use to post-process those photos (helicon or stack-photos command) asks you to group all the photos that belong to the same series in a common folder. This PR tries to solve this part acting when the file is going to be saved on a stack-photo session: adds the name of the photo (but not its index) as parent folder, so the result is a zip folder that contains as many folders as photos where chosen and all photos sorted in their own directories.

Why: To remove a post-process step that is annoying if you don't have basic console command skills. But most importantly, to remove a step that is time-consuming.

swittman commented 11 months ago

This change makes too many assumptions about the intended workflow. This should at minimum be hidden behind a settings switch that defaults to off, otherwise this will break every workflow established over the history of the stacked focus feature.

stealthizer commented 11 months ago

Mantaining the actual behaviour (zip fies contain all fotos in plain structure) and added a feature-flag on the settings->camera options to enable the nesting ofall related stacked photos into their own folders