search

OpenSchulportfolio / dokuwiki-plugin-menu

1 stars 1 forks source link

Inconsistent scaling #7

Open ironiemix opened 5 years ago

ironiemix commented 5 years ago

I dont know enough of flex to determine the cause of inconstistent scaling of the icons when using different devices:

scaling

zioth commented 5 years ago

What's the dokuwiki markup that produces this?

ironiemix commented 5 years ago 
<menu col=2,align="left",caption="">
<item>Leitfaden|Ein praxistauglicher Rundgang durch das QG|aktuelles:leitfaden|:shared:icons:help-browser-40x40.png</item>
<item>Infocenter|Aktuelle Infos|aktuelles:start|shared:icons:information_40x40.png</item>
<item>Formularcenter|Anträge, Vorlagen und Formulare|portfolio:formulare:start|:shared:icons:document-open-40x40.png</item>
<item>Projekte|Projekte und Arbeitsgruppen|projekte:start|:shared:icons:applications-development-40x40.png</item>
<item>Fächer|Schulcurriculum, Infos aus den Fachbereichen|portfolio:fachbereiche:start|:shared:icons:system-file-manager-40x40.png</item> 
<item>Netz & Medien|Schulnetzwerk und Medien|portfolio:prozesse:netz_und_medien:start]|:shared:icons:network-server-40x40.png</item>
<item>Selbstevaluation|SEV AuV 2017/18|portfolio:qualitaetsentwicklung:selbstevaluation:2017-18_auv:start|:shared:icons:edit-find-replace-40x40.png</item>
</menu>

And BTW - the second column is not showing... But I have no idea if thats got anything to do with your changes.

zioth commented 5 years ago

According to the documentation, images have to be in curly braces:

<item>Leitfaden|Ein praxistauglicher Rundgang durch das QG|aktuelles:leitfaden|{{:shared:icons:help-browser-40x40.png?direct&40x40}}</item>

With your current code, the images will render in their native size, which might not always be 40x40.

Not sure about the second column not showing. I tried your markup, and I see both columns, regardless of window width.

zioth commented 5 years ago

Is your site public? If you give me a url, I might be able to figure out more.

diolwe commented 5 years ago

Curly brackets around pictures seem to be unnecessary. What helped here https://www.kvfg.net/benutzerordnung/doku.php?id=dienste (and also in two more cases) is to remove the caption!

Wild guess: The problem might have to do with a missing "break" oder "new line" or "clear" after the caption-line??

zioth commented 5 years ago

Thanks. I forgot to test captions. This should fix the caption layout issue: https://github.com/ironiemix/dokuwiki-plugin-menu/pull/9

The reason you're seeing the scaling issue is that width and height are not specified on your images, due to using non-wiki syntax to add them. If you used the curly braces, they would work properly. But anyway, my latest pull request should fix your page (without having to use curly braces).