OpenSecuritySummit / oss2019

Open Security Summit 2019
https://2019.open-security-summit.org
25 stars 118 forks source link

Ambiguity conflict between equally names tracks and teams #46

Closed bkimminich closed 5 years ago

bkimminich commented 5 years ago

image

Having a team with the same name as a track will make some (or maybe even all) generated links go to the team instead of the track.

Workaround: Do not use identical names for tracks and teams, duh! :grinning:

fzipi commented 5 years ago

I think that it is a bug in the teams partial.

fzipi commented 5 years ago

Well, I can't reproduce that in production. Links are generated using the type: in the front matter. So it should generate the correct one if the type is track or team.

@bkimminich Could you provide more info about it?

bkimminich commented 5 years ago

I deleted the team OWASP Juice Shop until this gets fixed. If you create any team with the same name as an existing track you should experience this issue.

fzipi commented 5 years ago

Will try using that, thx.

fzipi commented 5 years ago

Could you please add again your team? Thanks!

bkimminich commented 5 years ago

Done, PR is up!

bkimminich commented 5 years ago

Still not fixed. Try going to https://open-security-summit.org/tracks/owasp-juice-shop/working-sessions/juice-shop-hackathon2/ and then click the "Track" link to "OWASP Juice Shop". It will send you to https://open-security-summit.org/teams/owasp_juiceshop/ instead of expected https://open-security-summit.org/tracks/owasp_juiceshop/.

fzipi commented 5 years ago

Weird. It doesn't...?

bkimminich commented 5 years ago

I guess Hugo doesn't know the difference between types. If you create a participant named "OWASP Juice Shop" I'm pretty sure link will all go there as its alphabetically seen first by Hugo... Just a wild guess... 🤔

fzipi commented 5 years ago

Well, it's not hugo, is how we use it :( That specific step is generic, so we weren't checking the document's type. But I think we should rewrite it.

Will create a new issue with the generic problem, so we can think in a more generic solution.