search

OpenSeizureDetector / Garmin_SD

Garmin Watch Seizure Detector - A seizure detector data source based on Garmin IQ watches such as Vivoactive HR
http://openseizuredetector.org.uk
GNU General Public License v3.0
12 stars 8 forks source link

54 retry mechanism doesnt work and cannot work properly #56

Closed pmithrandir closed 7 months ago

pmithrandir commented 7 months ago
jones139 commented 7 months ago

Thanks for preparing this - I'll look at it this evening.

jones139 commented 7 months ago

Please will you update it to target the develop branch rather than master? It looks like lots of changed files, but I think that is just because it includes lots of other changes in develop.

jones139 commented 7 months ago

I realised I can change the target branch so have done it, thanks

jones139 commented 7 months ago

The change looks ok to me, but I am getting frequent ERR:MISSED warnings, followed very quickly (<<1sec) by it going back to OK. Sometimes the ERR:MISSED stays on for about 1 second though.

Also 'MISSED' is probably not obvious to most people - how about 'COMMS' to say it is a problem with communications?

pmithrandir commented 7 months ago

I updated for the COMMS, make more sense.

I didn't get any retry today during my tests... will test it again in case of. Maybe it could be because I reduces the timeout... but 2 sec is quite ok normally. After, I keep the phone always close to the watch, and my tests included as well the branch with no less data. could impact that as well.

jones139 commented 7 months ago

I think the issue was that I had built the version from the 54-*** branch and it did not include the changes to send only 3d data - it was still sending vector magnitude data. I am probably doing something wrong with banches and merging! I'll try testing it again.

pmithrandir commented 7 months ago

I rebased 54 on top of develop so now everything should be included.

I'll try to test it tomorrow. Tonight, the watch is on son arm.

jones139 commented 7 months ago

Thanks - all looks good now - will merge this into develop.