OpenSenseAction / OPENSENSE_sandbox

Collection of runable examples with software packages for processing opportunistic rainfall sensors
BSD 3-Clause "New" or "Revised" License
9 stars 16 forks source link

Add OpenMRG usecase #56

Closed maxmargraf closed 1 year ago

maxmargraf commented 1 year ago

This PR is discussed in #49 It adds

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a binder notebook on branch _maxmargraf/OPENSENSE_sandbox/add_openMRGusecase

cchwala commented 1 year ago

Thanks @maxmargraf. Looks already pretty good, and also very concise!

Some comments regarding the notebooks:

  1. I suggest to put this use case as the first item in the index notebook since it is the one that people should check out first.
  2. Can you show some 1h-maps, maybe 3x3 subplots (or an animation 😁 😇 ) of the resulting CML rainfall maps?
  3. Yes, very short CMLs are still a mystery, or WAA is just higher than I expect. Have you tried with more WAA_max?
  4. Any chance to add the radar data now for visual comparison?
eoydvin commented 1 year ago

There is a small conflict between the naming of polarization. pycomlink accepts 'v', 'V', and 'h', 'H', but the recommended opensense format is 'vertical' and 'horizontal'. Its still a recommendation so I'm not so sure how much weight to put on this?

maxmargraf commented 1 year ago

I can include 1 and 2. For 3, WAA probaly should be added based on length and the short ones defintely need more WAA, but thats probaly too much for a short example. REgarding the reference, I tried different days and I could not find one with a at least ok looking match. The radar data is not the most trustworthy, short CMLs overestimate in the city center, while the few CMLs in the south also do not match the radar perfectly.. Here is one example for the 15 August: image

maxmargraf commented 1 year ago

There is a small conflict between the naming of polarization. pycomlink accepts 'v', 'V', and 'h', 'H', but the recommended opensense format is 'vertical' and 'horizontal'. Its still a recommendation so I'm not so sure how much weight to put on this?

That is on the todo list for pycomlink. We will aim to use 'vertical' and 'horizontal' in the future.

EDIT: Required updated to pycomlink can be discussed here https://github.com/pycomlink/pycomlink/issues/125

cchwala commented 1 year ago

I can include 1 and 2. For 3, WAA probaly should be added based on length and the short ones defintely need more WAA, but thats probaly too much for a short example. REgarding the reference, I tried different days and I could not find one with a at least ok looking match. The radar data is not the most trustworthy, short CMLs overestimate in the city center, while the few CMLs in the south also do not match the radar perfectly..

Okay. I see. Not easy to solve that now till tomorrow...

Maybe you could exclude the very short CMLs, maybe shorter than 500m or even shorter then 1000m, in particular if they have frequencies below 30 GHz?

Bildschirmfoto 2023-06-27 um 11 08 15
maxmargraf commented 1 year ago

Maybe you could exclude the very short CMLs, maybe shorter than 500m or even shorter then 1000m, in particular if they have frequencies below 30 GHz?

That is almost what the map above already shows - removing CMLs which are either shorter than 1km, show more than 200 mm/d on that day or without rainfall in the whole three month period.

maxmargraf commented 1 year ago

Updated the notebook including the comments from @cchwala above. I did not add an animation, combining pcolormesh with matplotlib.animation as well as adding a CML line plot is a bit tricky. But there should definitley be a solution similar to the example shown here: https://gist.github.com/tenomoto/dc7ff221c832db4c90832eb21f4b2f48#file-animation-ipynb

cchwala commented 1 year ago

Thank again! 👍 I am merging this now 🎉 🚀

We can discuss offline some potential small improvements that can be done later.