search

OpenSenseAction / OPENSENSE_sandbox

Collection of runable examples with software packages for processing opportunistic rainfall sensors
BSD 3-Clause "New" or "Revised" License
13 stars 16 forks source link

add code and example of PWSQC #9

Closed LottedeVos closed 2 years ago

LottedeVos commented 2 years ago

I have tried to add the packages needed for the PWSQC method. I have duplicated the style of the other R-packages by prefixing "- r-", although I'm not sure that is correct. The required R-packages from CRAN are: data.table (for preprocessing in PWSQC_0.R) geosphere (for PWSQC_1) sf (for PWSQC_1_alternativeversion.R) s1 (for PWSQC_1_alternativeversion.R) TeachingDemos (for visualization in PWSQC_4.R)

github-actions[bot] commented 2 years ago

Binder :point_left: Launch a binder notebook on branch _LottedeVos/OPENSENSEsandbox/patch-1

maxmargraf commented 2 years ago

I'd suggest to change this PRs name from Update environment.yml to something like add code and example of PWSQC.

cchwala commented 2 years ago

@LottedeVos Thanks for the update. I am not familier with R notebooks, though. How does one run the code in the binder? Do I need to run the rmd file in RStudio? If I try that, I get a lot of errors. I guess I am doing something wrong.

LottedeVos commented 2 years ago

Hello @cchwala, to be honest I'm not quite sure. I worked out the way to connect the R notebook to github with Martin, @fenclmar, do you know how to run the code now that it is pushed?

maxmargraf commented 2 years ago

PWSQC_minimal_example.ipynb is now providing a minimal running example of the HI and VI flagging from PWSQC with some visualization. At the moment no code from the submodule is used and the complete notebook PWSQC_allscripts.ipynb including the SO flagging is WIP. The main reason for this is the long runtime of the SO flagging. We now have, IMHO, two options: 1) merge as is and use the minimal example as showcase during the meeting or 2) remove the WIP files for the moment to have an "as-clean-as-possible" repo and work on it in a new PR.

LottedeVos commented 2 years ago

Thank Max! Both options would work but I'd prefer to keep the allscripts version available as this may give insight in the SOfilter and biascorrection.

cchwala commented 2 years ago

Thanks @LottedeVos and @maxmargraf

I will merge it now as is to have all showcases combined in the main branch as a demo for today's meeting. We can iterate further in a new PR.