search

OpenSenseAction / mergeplg

Merging methods for rainfall sensor data provided as point, line and grid
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Add additive radar-CML merging with IDW and with Krignig, plus example data #3

Closed eoydvin closed 1 month ago

eoydvin commented 3 months ago

This PR implements parts of what is discussed in #2

src/mergeplg/merge.py:

src/mergeplg/interpolator.py and src/mergeplg/idw.py:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@c39e20c). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3 +/- ## ======================================== Coverage ? 100.00% ======================================== Files ? 2 Lines ? 89 Branches ? 0 ======================================== Hits ? 89 Misses ? 0 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cchwala commented 3 months ago

A lot of green check marks now! 🎉

Thanks @eoydvin. I will look into the details next week.

cchwala commented 3 months ago

You can remove the pypy-3.10 test runs (I guess somewhere in the CI config). We do not test pypy in poligrain.

eoydvin commented 3 months ago

I also have some KED prototype files now, but then the tests will not run anymore. Should we just keep it like this for now then?

cchwala commented 3 months ago

Yes. Let's keep this PR focused on what you already have and add KED in another PR.

I will have a look this week.

cchwala commented 1 month ago

Sorry for the long delay 🙈. I now finally had a quick look at the code and notebook. Looks really good 👏 👏 👏 . Of course, we will have to see/discuss how we define a common higher-level interface for the different functions. But this is a very good starting point. I am merging this now. Once I have my PR #6 ready or merged we should start the discussion about aligning the code, i.e. finding the mentioned common "interface".