Closed maxmargraf closed 3 months ago
To overcome the issue of descending lon/lat coordinates there should be a check based on this raise that checks if lon or lat are descending and if true, a flip along the respective axes e.g. like here.
We should raise an error in calc_intersect()
if lat or lon coords are not ascending (like its correctly raised right know in _calc_grid_corners_for_lower_left_location()
. The error should add a code snippet how to flip on or lat OR we add an option to automatically flip the coords to be ascending ~BUT we happens if we have a grid over the equator and on the southern hemisphere?
--> what do we do with a global grid with lower left definition of the grid??~
--> all (sub-)global grids should work because they are typically ascending from bottom left to top right
Additionally, the offset for the bounding box should be calculated in the center of the grid and should be always positive
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
61c4063
) to head (9bd47f3
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary of recent changes:
.toml
filepixel_poly_list
Open to suggestions but ready to be merged from my side-
🎉 Thanks @maxmargraf
This PR should add the calculation of the weights of the grid intersections between line and grid from pycomlink to close #5.