Add simple API to get GridAtLines and GridAtPoints

OpenSenseAction / poligrain

Simplify common tasks for working with point, line and gridded sensor data, focusing on rainfall observations.

https://poligrain.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2 stars 10 forks source link

Add simple API to get GridAtLines and GridAtPoints #41

Closed cchwala closed 1 week ago

cchwala commented 3 months ago

TODO in this PR:

[x] Add GridAtPoints (based on RawAtObs of wradlib) and GridAtLines (based on our grid intersection code)
[x] Add an own copy-pasted and simplified version of RawAtObs since we do should not have wradblib as dependency
[x] Add example notebook
[x] clean up (a lot...) and add tests

Checklist:

[ ] closes nothing (but builds on #19)
[x] Tests added and passed if fixing a bug or adding a new feature
[x] All code checks from pre-commit passed
[x] Added an entry in the CHANGELOG.md file

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (61c4063) to head (48e3919). Report is 18 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 3 4 +1 Lines 43 321 +278 ========================================== + Hits 43 321 +278 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cchwala commented 1 week ago

I checked if the CI errors also occur outside of this PR, see #58. Since CI works fine there and since I have not found any info on what could be the cause of the problem here, I will try to adjust the config of pytest so that the ResourceWarning raised in jsonschema is ignored.

Here are the related docs of pytest.

cchwala commented 1 week ago

I have iterated the tests back and forth on my local machine (deliberately generating red test and switching back to green again) and I am confident that they cover the functionalities in a good way. I also have polished the notebook two times or so and it looks good to me after coming back to it after some days. Hence, I am merging now without a code review.