search

OpenShelter / fastlane-plugin-rome

Fastlane plugin for Rome, a S3 cache tool for Carthage
https://rubygems.org/gems/fastlane-plugin-rome
Other
17 stars 5 forks source link

meet_minimum_version function returns false negative #9

Closed piellarda closed 5 years ago

piellarda commented 5 years ago

https://github.com/OpenShelter/fastlane-plugin-rome/blob/3dc5afd868556b1506d02fd46e1b21d3320d6b75/lib/fastlane/plugin/rome/actions/rome_action.rb#L46

It's comparing each part of the version until one if inferior so: 0.13.1.35 - minimum 0.18.0.51 - current This for example returns false.

tmspzz commented 5 years ago

Good point. This seems wrong, thanks for reporting!

tmspzz commented 5 years ago

@piellarda this should be fixed in 0.3.5