OpenShiftDemos / openshift-ops-workshops

Workshop materials for OpenShift admin training, covering Red Hat OpenShift Container Platform 4, Modern App Dev Roadshow's Ops Track, and Summit 2023 Hands-on with OCP Plus.
GNU General Public License v3.0
119 stars 153 forks source link

AMI id for "workerocs" MachineSet #607

Closed bszeti closed 3 years ago

bszeti commented 3 years ago

In the lab "OpenShift and Container Storage for Admins" the section "Deploying and Managing OpenShift Container Storage" creates a new MachineSet for OCS. The machine's AMI id in this file doesn't seem to work. https://github.com/openshift/openshift-cns-testdrive/blob/ocp4-dev/support/ocslab_cluster-workerocs.yaml#L34

Maybe there should be a step to update the id to the current cluster's worker node's AMI id.

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

christianh814 commented 3 years ago

/remove-lifecycle stale

christianh814 commented 3 years ago

@bszeti Where are you using this YAML? This YAML isn't used in the workshop. Instead the AMI is gleaned from the following command

bash /opt/app-root/src/support/machineset-generator.sh 3 workerocs 0 | oc create -f -
oc get machineset -n openshift-machine-api -l machine.openshift.io/cluster-api-machine-role=workerocs -o name | xargs oc patch -n openshift-machine-api --type='json' -p '[{"op": "add", "path": "/spec/template/spec/metadata/labels", "value":{"node-role.kubernetes.io/worker":"", "role":"storage-node", "cluster.ocs.openshift.io/openshift-storage":""} }]'
oc get machineset -n openshift-machine-api -l machine.openshift.io/cluster-api-machine-role=workerocs -o name | xargs oc scale -n openshift-machine-api --replicas=1

Where are you seeing instructions to use this YAML?