OpenShiftDemos / openshift-tasks

Sample JBoss EAP (WildFly) App for OpenShift
47 stars 425 forks source link

Clustering enabled #9

Closed siamaksade closed 8 years ago

thoraxe commented 8 years ago

Why did you:

-- remove webhook secret generation? -- use hardcoded passwords? -- remove probe configuration settings?

siamaksade commented 8 years ago

Since it's a demo, security is of no concern. Removed to make the template shorter. Probe config is removed by mistake. Should add them back

thoraxe commented 8 years ago

Why is the length of the template of concern? Security is always a concern and any demo is considered simultaneously an example. There's no reason to have gotten rid of it -- template "length" is not really a good reason. Someone is going to look at this template and potentially base something off of it. Why not follow best practices? It was already done -- you actually had to do work to remove the best practice in favor of shorter template length. That seems really arbitrary and silly to me...

siamaksade commented 8 years ago

Lengthly templates are scary to new users, particularly when they are coming from Compose. Security has nothing to do with this demo and therefore is of no concern, while making it developer friendly is one of the most important parts of a demo. Not sure what best practise you are referring to but that template needs lots of other things to be able to refer to it as a "do it this way in production" type of scenario.

Changing something that is already done to align with the goal is a known practise and has a name! called refactoring, regardless of what it seems to you.

thoraxe commented 8 years ago

I give up. All yours.