OpenShock / Firmware

Espressif Firmware for OpenShock, Controlling shock collars via Reverse engineered proprietary Sub-1 GHz Protocols.
GNU Affero General Public License v3.0
26 stars 6 forks source link

[Bug] [CI] Restore old naming scheme for release firmware bin #198

Closed LucHeart closed 4 months ago

LucHeart commented 4 months ago

With 1.1.0 the naming scheme for the firmware merged bin's has changed. It does NOT include the version anymore. This leads to not knowing what firmware version a certain bin is.

This was previously different, dont exactly know why it was changed.

E.g. currently: OpenShock_Wemos-D1-Mini-ESP32_stable

What it should really be is something like: OpenShock_Wemos-D1-Mini-ESP32_stable_1.1.1 for beta this would be OpenShock_Wemos-D1-Mini-ESP32_beta_1.1.1-rc.1

hhvrc commented 4 months ago

I would change it to OpenShock_Wemos-D1-Mini-ESP32_1.1.1 rather than OpenShock_Wemos-D1-Mini-ESP32_stable_1.1.1

as 1.1.1 already indicates that its stable

LucHeart commented 4 months ago

just for stable? would keep for beta thought

hhvrc commented 4 months ago

This would apply for all release channels