OpenShock / Firmware

Espressif Firmware for OpenShock, Controlling shock collars via Reverse engineered proprietary Sub-1 GHz Protocols.

GNU Affero General Public License v3.0

33 stars 13 forks source link

Allow setting/disabling Emergency Stop during setup/via Serial commands #269

Closed hhvrc closed 2 months ago

hhvrc commented 3 months ago

Allows enabling/disabling EStop without needing to change the compile-time constant.

Default pin is still obtained via OPENSHOCK_ESTOP_PIN

Using a pin of 0 (GPIO_INVALID in Common.h) in either the Captive Portal or via Serial will disable the EStop manager.

Remaining tasks:

[ ] Captive Portal formatting seems to be affected, need to fix.
[x] Need to further test updating to this from old firmwares (so far, works correctly)

Original PR: #228 by @nullstalgia

github-actions[bot] commented 2 months ago

Cpp-Linter Report :warning:

Some files did not pass the configured checks!

clang-format reports: 5 file(s) not formatted

- include/serialization/_fbs/HubConfig_generated.h - include/serialization/_fbs/HubToLocalMessage_generated.h - include/serialization/_fbs/LocalToHubMessage_generated.h - src/CompatibilityChecks.cpp - src/config/EStopConfig.cpp

Have any feedback or feature suggestions? Share it here.