OpenShock / Firmware

Espressif Firmware for OpenShock, Controlling shock collars via Reverse engineered proprietary Sub-1 GHz Protocols.
GNU Affero General Public License v3.0
33 stars 13 forks source link

Add support for runtime hostname configuration #287

Closed hhvrc closed 2 months ago

github-actions[bot] commented 2 months ago

Cpp-Linter Report :warning:

Some files did not pass the configured checks!

clang-tidy reports: 11 concern(s) - **include/config/Config.h:3:10:** error: [clang-diagnostic-error] > 'config/BackendConfig.h' file not found ```h 3 | #include "config/BackendConfig.h" | ^~~~~~~~~~~~~~~~~~~~~~~~ ``` - **src/CaptivePortal.cpp:1:10:** error: [clang-diagnostic-error] > 'freertos/FreeRTOS.h' file not found ```cpp 1 | #include | ^~~~~~~~~~~~~~~~~~~~~ ``` - **src/CaptivePortal.cpp:61:15:** warning: [[cppcoreguidelines-init-variables](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/init-variables.html)] > variable 'hostname' is not initialized ```cpp 61 | std::string hostname; | ^ | = 0 ``` - **src/config/Config.cpp:1:10:** error: [clang-diagnostic-error] > 'freertos/FreeRTOS.h' file not found ```cpp 1 | #include | ^~~~~~~~~~~~~~~~~~~~~ ``` - **src/serial/SerialInputHandler.cpp:1:10:** error: [clang-diagnostic-error] > 'serial/SerialInputHandler.h' file not found ```cpp 1 | #include "serial/SerialInputHandler.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` - **src/serial/SerialInputHandler.cpp:299:6:** warning: [[bugprone-reserved-identifier](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/reserved-identifier.html)] > declaration uses identifier '_handleHostnameCommand', which is reserved in the global namespace ```cpp 299 | void _handleHostnameCommand(std::string_view arg) { | ^~~~~~~~~~~~~~~~~~~~~~ | handleHostnameCommand ``` - **src/serial/SerialInputHandler.cpp:301:17:** warning: [[cppcoreguidelines-init-variables](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/init-variables.html)] > variable 'hostname' is not initialized ```cpp 301 | std::string hostname; | ^ | = 0 ``` - **src/serial/SerialInputHandler.cpp:312:8:** warning: [[cppcoreguidelines-init-variables](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/init-variables.html)] > variable 'result' is not initialized ```cpp 312 | bool result = OpenShock::Config::SetWiFiHostname(arg); | ^ | = false ``` - **src/serial/SerialInputHandler.cpp:314:3:** warning: [[bugprone-branch-clone](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/branch-clone.html)] > if with identical then and else branches ```cpp 314 | if (result) { | ^ /home/runner/work/Firmware/Firmware/src/serial/SerialInputHandler.cpp:318:5: note: else branch starts here 318 | } else { | ^ ``` - **src/serial/SerialInputHandler.cpp:323:6:** warning: [[bugprone-reserved-identifier](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/reserved-identifier.html)] > declaration uses identifier '_handleNetworksCommand', which is reserved in the global namespace ```cpp 323 | void _handleNetworksCommand(std::string_view arg) { | ^~~~~~~~~~~~~~~~~~~~~~ | handleNetworksCommand ``` - **src/wifi/WiFiManager.cpp:1:10:** error: [clang-diagnostic-error] > 'wifi/WiFiManager.h' file not found ```cpp 1 | #include "wifi/WiFiManager.h" | ^~~~~~~~~~~~~~~~~~~~ ```

Have any feedback or feature suggestions? Share it here.