OpenShopChannel / Apps

Open Shop Channel Applications Repository
https://docs.oscwii.org/repository-manager
39 stars 22 forks source link

Remove Wii Mod Lite #23

Closed emilydaemon closed 6 months ago

emilydaemon commented 12 months ago

A lengthy discussion about Wii Mod Lite and why it is bad has gone on here: https://github.com/RiiConnect24/Wii-Guide/pull/360

Artuto commented 12 months ago

I don't see a concrete reason why Wii Mod Lite "has gone bad".

Users installing the wrong System Menu version for their systems is their responsibility.

We are not here to correct user error, this is an app repository where both apps can co-exist and users can choose which one they want to use.

Unless the app does something malicious on purpose, I don't see why we should remove it.

DardelHMB commented 11 months ago

Wii Mod Lite has always been bad.

As mentioned in the PR emily linked, it lacks important safety checks that yawmME has that prevent a bad system menu from being installed.

The tool is also closed source, we have no way of contacting the author. By being closed source, it is also ILLEGAL since it breaks the GPL, since the tool is a fork of Wii Mod and uses code from lots of different programs, like Waninkoko's WAD Manager 1.7, which is licensed under GPL.

playerjmr commented 11 months ago

Not to mention, it has issues with freezing when deleting certain titles, and also freezing when navigating too many menus. Generally it isn’t a good idea to include those multitools inside of what is supposed to be a wad manager anyway, especially in particular the region changer. People who don’t know what they are doing can really mess up their Wii like that.

GabubuAvailable commented 11 months ago

In short we need to remove it... WML caused lots of problems and these are specified here by the others.

Users installing the wrong System Menu version for their systems is their responsibility.

It's true but you see, WML doesn't even warn you about that, while YAWMME does.

playerjmr commented 11 months ago

Users installing the wrong System Menu version for their systems is their responsibility.

We are not here to correct user error, this is an app repository where both apps can co-exist and users can choose which one they want to use.

By this logic KoreanKii should be added back as well.

vgmoose commented 10 months ago

Hi! I'm chiming in because this issue came up when discussing using OSC API for the hb-appstore project. I'm also in favor of the removal, or seeking license clarification.

For:

I don't see a concrete reason why Wii Mod Lite "has gone bad".

This seems notable:

[T]he tool is a fork of Wii Mod and uses code from lots of different programs, like Waninkoko's WAD Manager 1.7, which is licensed under GPL.

If the app isn't complying with GPL (where redistributing the full source code is one of the sublicense requirements), then it's infringing on the copyright of the original authors of those projects.

This might not be an issue for the author of WML in the context where it was originally distributed (for example if China has more relaxed copyright laws). However, it would still be an issue when redistributing it outside of that context.

From the other discussion on this:

[T]he Lite version was made by a person in China, I believe that it breaks the GPL license because the author didn't share its code.

That's true! But "breaks the GPL" in this context means "violates the terms of the license", which is a copyright infringement. I don't think it's hyperbole to say that you could use that same line of reasoning to justify redistributing retail Wii games, as long as a Chinese user modified it first.

KokiKitsune2007 commented 10 months ago

NGL I was a little suspicious when I couldn't find Wii Mod Lite's source code. I also, couldn't find a trace of Jskyboo himself on Github! But yeah, we can all agree that WiiMod Lite has to go.

DardelHMB commented 7 months ago

Will it be removed or not? If not, I (among many others) would like to hear your reasoning behind it. I see no reason why it should be on the Open Shop Channel.

KokiKitsune2007 commented 7 months ago

Lol, I forgot about this topic but Idk, All I know is I found the original source code for WiiMod (the original app before WiiMod lite). Jskyboo licensed it under GPL 3.0. I could send a link to it if you guys wanna see

korbosoft commented 7 months ago

Please do.

KokiKitsune2007 commented 7 months ago

https://archive.org/details/wiimod

Please note that all source is found in the zip file

KokiKitsune2007 commented 7 months ago

You can tell it's old because it doesn't have the "apply patches please wait.." screen.

One more thing, we don't know if kkline38 is violating gpl. I mean he might've asked Jskyboo to grant him an exception with making it closed source privately. Someone might have to ask him if he granted KKline38 permission.

playerjmr commented 7 months ago

One more thing, we don't know if kkline38 is violating gpl. I mean he might've asked Jskyboo to grant him an exception with making it closed source privately. Someone might have to ask him if he granted KKline38 permission.

if an exception was granted, don’t you think he wouldn’t have avoided being contacted if there was? Anyway it still doesn’t matter because regardless the app cannot be updated so it should be removed.

korbosoft commented 7 months ago

We are not here to correct user error

@Artuto Even then, it still, violates the GPL. If you are OK with this, then you are OK with copyright infringement. Please make the right decision.

KokiKitsune2007 commented 7 months ago

One more thing, we don't know if kkline38 is violating gpl. I mean he might've asked Jskyboo to grant him an exception with making it closed source privately. Someone might have to ask him if he granted KKline38 permission.

if an exception was granted, don’t you think he wouldn’t have avoided being contacted if there was? Anyway it still doesn’t matter because regardless the app cannot be updated so it should be removed.

True, but yeah, I think it might be confirmed that Kkline38 is violating gpl. Cause Jskyboo licensed WiiMod under gpl 3.0

korbosoft commented 7 months ago

At this point it feels like we are just being ignored.

KokiKitsune2007 commented 7 months ago

At this point it feels like we are just being ignored.

Same... I feel like we are

DardelHMB commented 7 months ago

@Artuto in case it wasn't clear, we are waiting for your response.

Artuto commented 7 months ago

A decision hasn't been made

xflak commented 7 months ago

If I'm not too late to the party, I'd like to add that I agree with it's removal. If someone wants to use this brick risk of a tool, let's make it a bit more difficult to find.

KokiKitsune2007 commented 7 months ago

If I'm not too late to the party, I'd like to add that I agree with it's removal. If someone wants to use this brick risk of a tool, let's make it a bit more difficult to find.

Yeah, I agree with you XFlak, I mean, it seems WiiMod lite is at least 13 years old lol. If only kkline38 kept maintaining it and actually followed gpl.

korbosoft commented 6 months ago

its been a month.

KokiKitsune2007 commented 6 months ago

its been a month.

Did they never say anything or remove it?

GriffintheFolf commented 6 months ago

No, not at this point in time.

KokiKitsune2007 commented 6 months ago

No, not at this point in time.

Aight, well they better remove it soon.

KokiKitsune2007 commented 6 months ago

Aight, well they better remove it soon.

If it has taken this long just to make a decision on if they should violate copyright law or not, they probably aren't going to.

Yeah, probably not lol

korbosoft commented 6 months ago

@Artuto I'm not sure what there is to decide. Wii Mod Lite violates copyright law, which means if the creator of Wii Mod, who is seemingly still on the internet to this very day, wanted to, they would be able to wipe this entire repository off of github if you didn't comply.

KokiKitsune2007 commented 6 months ago

@Artuto I'm not sure what there is to decide. Wii Mod Lite violates copyright law, which means if the creator of Wii Mod, who is seemingly still on the internet to this very day, wanted to, they would be able to wipe this entire repository off of GitHub if you didn't comply.

I'm honestly surprised that jskyboo is not taking action. It might be because he gave the creator of wii mod lite permission to keep it closed source. I mean look at riivolution, it uses libwiigui and it is open source but riivolution is not. They didn't violate anything because the riivolution team ask tantric if they can make it closed source.

https://gbatemp.net/threads/riivolution-violates-gnu-gpl.252764/

playerjmr commented 6 months ago

@Artuto I'm not sure what there is to decide. Wii Mod Lite violates copyright law, which means if the creator of Wii Mod, who is seemingly still on the internet to this very day, wanted to, they would be able to wipe this entire repository off of GitHub if you didn't comply.

I'm honestly surprised that jskyboo is not taking action. It might be because he gave the creator of wii mod lite permission to keep it closed source. I mean look at riivolution, it uses libwiigui and it is open source but riivolution is not. They didn't violate anything because the riivolution team ask tantric if they can make it closed source.

https://gbatemp.net/threads/riivolution-violates-gnu-gpl.252764/

Riivolution is actually open source and the code can be found at ArielX/rawksd. That’s an outdated gbatemp thread

KokiKitsune2007 commented 6 months ago

@Artuto I'm not sure what there is to decide. Wii Mod Lite violates copyright law, which means if the creator of Wii Mod, who is seemingly still on the internet to this very day, wanted to, they would be able to wipe this entire repository off of GitHub if you didn't comply.

I'm honestly surprised that jskyboo is not taking action. It might be because he gave the creator of wii mod lite permission to keep it closed source. I mean look at riivolution, it uses libwiigui and it is open source but riivolution is not. They didn't violate anything because the riivolution team ask tantric if they can make it closed source. https://gbatemp.net/threads/riivolution-violates-gnu-gpl.252764/

Riivolution is actually open source and the code can be found at ArielX/rawksd. That’s an outdated gbatemp thread

Oh, ok.

Artuto commented 6 months ago

After consideration of all the arguments provided in this thread, and internal discussion with the other team members, the following has been decided:

  1. Due to the lack of feasible alternatives for some features, like title deleting, a notice will be placed on the WML page in the library stating that its use is discouraged, and that more modern alternatives should be used where possible.
  2. Regarding the license, we have concluded that we do not have all the elements necessary to say that the license is being broken with malicious intent, as such, we will not be removing the app.

We will always honor copyright takedown requests coming from the original copyright holder via our support email (support [at] oscwii.org), and this is in no way opening the doors to apps that do break the license in malicious manners.