search

OpenShot / openshot-qt

OpenShot Video Editor is an award-winning free and open-source video editor for Linux, Mac, and Windows, and is dedicated to delivering high quality video editing and animation solutions to the world.
http://www.openshot.org
Other
4.34k stars 541 forks source link

Thumbnail For The Openshot Project File :) #1470

Closed ghost closed 6 years ago

ghost commented 6 years ago

System Details: Intel i5 Processor, Integrated GPU, 4GB RAM

Issue Description and steps to reproduce: I have designed a little thumbnail for the Openshot Project File, it does not look great but i tried

openshot project file icon

DylanC commented 6 years ago

@MrTertius - Thanks! Its good to even try, that is how we can improve things by learning more and doing better.

ghost commented 6 years ago

You are welcome.

peanutbutterandcrackers commented 6 years ago

How does the current windows thumbnail look right now?

@DylanC - Is this something we can change - the thumbnail that appears for a file pertaining to a program? I like this one.

@MrTertius - Awesome!

peanutbutterandcrackers commented 6 years ago

You'll probably have to attach a png with transparency, though - if you want the project to take it in. :)

ghost commented 6 years ago

That is a png file, i just checked

peanutbutterandcrackers commented 6 years ago

Yes. It is. I meant with transparency. I believe the white rectangular border around the blue boundary of the thumbnail probably isn't necessary/desirable. But I am not really sure.

Perhaps @ferdnyc might have some ideas. :)

ghost commented 6 years ago

Ok then

ferdnyc commented 6 years ago

Looks transparent to me. (Viewed in a new tab in Chrome...) screenshot from 2018-04-06 15-08-08

The only issues I'd raise are

  1. The rounded corners on the bottom. (Weird because the top-left isn't rounded.) Also, as you can see in my screenshot the background isn't transparent behind the rounded corners, there's a tiny bit of white.
  2. The diagonal isn't a straight line — it looks like it's in three segments, right now (possibly more), with two visible discontinuities along the path between the two corners. Removing those extra points and making it into a straight line would clean it up a little.

Also, if there's a vector source file the PNG is generated from (like an .SVG or similar), it couldn't hurt to have that as well. Linux supports .SVG icons, I'm guessing macOS does as well since I know support for scalable icons showed up there before anywhere else.

Thanks!

peanutbutterandcrackers commented 6 years ago

There you go! Nothing escapes @ferdnyc's eyes! Awesome! [Could you please also take a look at #1454, too, good sir?]

@MrTertius - I hope you will soon submit an enhanced thumbnail icon, good sir!

ferdnyc commented 6 years ago

It doesn't strike me that @MisterTeeXD is ever coming back, I guess this can be closed? The image isn't quite usable as-is, I'm afraid.

ghost commented 6 years ago

I will close this and in the meantime i will make an improved version of this, after all im not a pro graphics designer

ferdnyc commented 6 years ago

I will close this and in the meantime i will make an improved version of this, after all im not a pro graphics designer

Hey, none of us are! It was a strong start, just needs a bit of polish.

The most important things would be for the icon to be in structured-graphics form natively (an SVG from Inkscape or similar tool), that way it can be edited if necessary, and rendered to PNG from there at whatever sizes are required. But the vector form would be the primary source file. With the wide range of screen resolutions these days, more and more we're seeing SVG files used for even regular file/app icons, since they can be any size needed.

peanutbutterandcrackers commented 6 years ago

@MisterTeeXD - Please do use InkScape and InkScape only. It is Free Software. We do not want this amazing gem of a Free Software to be tainted with proprietary evil scum. Yeah, I've been watching/reading way too much Richard Stallman. :laughing: But seriously though, please do use InkScape to make it.

I'm so much of a free software guy that I look forward to the day when we'll have open graphics card and that will do all the hardware acceleration for Linux Distros and it'll be the Linux Kernel of graphics cards. I also wonder if OpenShot's default export profile should be ogg/vorbis or ogg/theora. Because freedom! lol

ferdnyc commented 6 years ago

Please don't listen. Software prescriptivism is as gauche as telling someone what sports team to root for. There's nothing wrong with using Libreoffice Draw to create a file icon. Or sK1. Inkscape is only one of at least a dozen free applications that can create SVG files.

And if you should happen to legally own and want to use Adobe Illustrator to create an OpenShot .osp icon, then that's perfectly fine too. Because it's your effort that's being donated to the project, not the software, and how you choose to put in that effort is, ultimately, really up to you. We're glad to have it all the same. ...Right?

ferdnyc commented 6 years ago

I also wonder if OpenShot's default export profile should be ogg/vorbis or ogg/theora. Because freedom! lol

Don't even joke about that. (Also, they wouldn't be an either/or — Ogg is the container, Theora the video codec, and Vorbis the audio codec. Analagous to an MP4 with H.264 video and AAC audio. You'd need all three, so an export profile for Ogg video would be something like ogg/theora+vorbis.)

Ogg is fine (though Matroska is far superior as a container). Vorbis was fairly good at the start, and pretty competitive with MP3, but it's been left behind since then, and MP4/AAC can run rings around it. Theora is the problem, though, as it's pretty much been crap since the beginning.

I wouldn't force or even encourage anyone but my worst enemy to use Theora video. (Which helps explain why the official list of hardware players that even support Theora is like four devices long and was last updated in 2010. And despite mumblings about Google Summer of Code projects from 2006(!) that are still featured on that page, the list of working hardware-accelerated Theora decoders is exactly this: [ ].

ETA: (I originally neglected to mention that, while it's true Vorbis was at one time a worthwhile free alternative to MP3 but has since been left behind, the bigger problem for Vorbis is that it's no longer necessary to have a free alternative to MP3. Now that the MP3 patents have expired, MP3 codecs can live under the free software umbrella, and MP3 support is natively available even in Libre OSes like Fedora. Whatever advantage Vorbis enjoyed simply by virtue of being free, that's lost now that MP3 enjoys the same status.)

peanutbutterandcrackers commented 6 years ago

I was just prescribing a free software to use. sigh lol :smile:

BTW, didn't know about sk1 project. Looks pretty cool. Should probably give it a try.

That comment was written half jokingly though. But yeah, I confess that I am a free software vegetarian now (Not yet a vegan). :laughing:

Also, that explains why ogg renders of OpenShot project look not-good-enough... :thinking:

peanutbutterandcrackers commented 6 years ago

But yes, @ferdnyc is right (as always), it is your effort that matters, @MisterTeeXD. :+1:

[But I would be happier if you used Free Software, though. But that's just me. :)]