OpenShot / openshot-qt

OpenShot Video Editor is an award-winning free and open-source video editor for Linux, Mac, and Windows, and is dedicated to delivering high quality video editing and animation solutions to the world.
http://www.openshot.org
Other
4.36k stars 545 forks source link

can not use video as mask #2968

Closed anegroo closed 5 years ago

anegroo commented 5 years ago

Describe the bug I would like to use a vide file as a mask for another video from timeline ( Since version 2.43 we could theoretically use a video file as mask (this can be read in description of 2.43). ). I copied the mask file to the ".openshot_qt\transitions" folder (i tried in many formats and codecs, even uncompressed) and it appears in OpenShot in the transitions list, but I can not drag and drop over the video from the Timeline. After that I can not drag and drop even the native mask files! In another case, If I tried first the native transitions or a simple custom mask, and it works. But when I try vith the video mask, OpenShot suddenly refuse to accept any mask from that point.

Steps to reproduce the behavior:

  1. Create a video for mask
  2. Copy it to the transitions folder
  3. It appears in the transitions list in the OpeShot interface
  4. Drag over the another video from timeline,
  5. See error: red mark - can not drag over

Expected behavior I use Openshot from a year ago, I introduce my students in video editing with the help of your great program, as a free alternative to Premiere. One important exercise is using masks and I was very happy, when appeared the possibility (in 2.43) to use video files as masks. I tried only in version 2.44 but is not working

System Details

Log Files

Exception / Stacktrace No stacktrace found in log files

Screenshots (Optional)

Screenshot

ferdnyc commented 5 years ago

@anegroo

Sorry for the delay in responding to this. The announcement mention of the new Mask/Transition video support was probably a little unclear about how exactly it works.

The change that was made in OpenShot 2.4.3 was to the Source property of both the Mask effect, and to Transitions on the timeline. Previously the only available Source values were the static .svg files in the transitions folder, but now if you right-click the Source property field, in addition to the supplied transition files, you can also select any of the items in Project Files to use as your Source. A grayscale copy of the image or video will be used as the alpha mask for the effect/transition.

Here's a quick example: image

I have two files imported here.

  1. A video to demonstrate on.
  2. "BouncyFun.mp4", a quick video I created in OpenShot from a still image. It's just the word "Fun" in black text, moving around on a white background.

You can see that I have my video on the timeline, with a Mask effect applied, and I've set "Bouncyfun.mp4" as the Source of the mask.

Farther down the timeline I have the same video again, without the mask, but after a couple of seconds I start a transition using BouncyFun.mp4 as the Source, and use that to crossfade into another video (actually the BouncyFun animation itself).

And here's what the result would be, converted to an animated GIF to ensure minimum possible quality and hopefully hide most of my shortcomings as an animator and video producer. :wink:

FunTest

SuslikV commented 5 years ago

@ferdnyc I don't know how you able to find this option and make it to work. It is bugged at menu level, sure. It works only from 6 or 7-th attempt or shows multiply menu entries with the same options each time I'm trying to bring this menu dialog up. Where exactly I should right-click (Windows)?

Edit: try to rapidly right-click over the Source property 6-7 times ^_^

ferdnyc commented 5 years ago

@SuslikV Really? Hmm. I've only tried it once or twice, myself, but I haven't had any problems with it so far. Here are the forms I've tried:

At least for the Files list, as I say I've had no problems with it.

The Transitions list (in the Source context menu) is admittedly a giant mess, but only because the sorting is crap — exactly like it is in the Transitions dock. If you set the Transitions dock to "Details View" you'll see that it's also a giant mess, with exactly the same crazy-pants sorting:

ferdnyc commented 5 years ago

Edit: try to rapidly right-click over the Source property 6-7 times ^_^

All I get is the submenu with "Files >" and "Transitions >" flashing on and off repeatedly. No issues here on Linux, at least.

In general, though, OpenShot completely builds every context menu from the ground up, for every invocation, only to throw the whole thing away again the very next time the user clicks either in- or outside of it. (Rather than simply hiding and reusing the same one, once it's been populated.) I wouldn't be surprised if that kind of inefficiency causes issues on at least some platforms.

SuslikV commented 5 years ago

@ferdnyc it is not about platform. Your PC is just not slow enough to click on the button before menu shown.

ferdnyc commented 5 years ago

@ferdnyc it is not about platform. Your PC is just not slow enough to click on the button before menu shown.

I'm still not clear on what exactly the issue is, because I can't see it. What happens when you rapidly right-click over the Source field 6-7 times?

anegroo commented 5 years ago

Hi Frank, excuse me for the late answer. I followed you explanation, and it works well. Thank you very much!

SuslikV commented 5 years ago

@ferdnyc

2019-09-13 19-31-20

ferdnyc commented 5 years ago

@SuslikV Heh, that's pretty screwy alright.

I'd suggest filing a new issue for that, so we can track it. It's unlikely that Source is the only place where that could happen, though right now it may be the only menu long/complex enough for it to actually happen.

@anegroo Glad I could help! Closing this as answered, though feel free to reopen if anything else comes up.

VisionaryMind commented 2 years ago

As of 2022, this feature is still not working on Linux platforms. It was apparently never fixed.