Open ghost opened 1 year ago
sc0nway
commented
1 year ago @DaveJarvis Thank you very much for submitting an issue. Your suggestions are an essential part of OpenShot's growing process. I have assigned this issue to @jonoomph, so he will review your comments and decide what actions are necessary for the rest of the team. If you have any other questions or concerns, please add them to this issue so we can follow up.
Colorjet3
commented
1 year ago Hello @DaveJarvis I went ahead and created internal tickets for many of your documented bugs/enhancements/feature requests. You can the links below. Please review them to ensure that I captured what you provided clearly. I also added my own thoughts/comments to some of them.
A few comments to you:
Need @jonoomph to review these and comment (these are in the thread above):
Submitted as Trello cards for @jonoomph to review.
Thank you again for your feedback. These are great feature/enhancement requests that will make Openshot even better. We look forward for your additional feedback and comments.
I am traveling the next 3 days returning next Monday so I will not be responding to any comments until then.
ghost
commented
1 year ago "Please fix the following and restart Openshot no channels". Build 10947 doesn't address the grammar issue you point out but the actual error may not manifest. Please try build 10947 and confirm either way.
Still happens with ./OpenShot-v3.0.0-daily-10947-510a7690-b5bbab66-x86_64.AppImage.
The key marker is skipped when too close. I am unable to reproduce this in Windows 10, Windows 11, or Ubuntu 22.04LTS. Please test with build 10947 and confirm either way.
Still happens. In the screenshot there are four markers:
The navigation buttons (to the right of the marker icon) skip all but one.
Overwriting prompt during the export. I am not able to replicate this. However, you may have clicked on Cancel during the Export.
That's likely.
Selecting multiple clips, then moving them, and then when you release the mouse, the clips still stay selected.
The reported problem is fixed, thank you. However, the selection is now a little "too sticky". Typically, a click on anything other than the selected collection would cause the selection to be removed. (The stickiness behaviour could be backed by a setting/checkbox.) Presently, users need to click on another track to deselect. This can be problematic if other tracks are full of clips.
The Ctrl and Shift operators don't quite work like boolean operators from other programs (such as Inkscape) and multi-select comboboxes: Ctrl+Click adds/removes a single clip from the selection. Shift+Click adds/removes a range.
For example:
Shift+click basically fills the gap between the previously selected clip and the currently clicked clip.
Ctrl+Shift+click acts as a boolean modifier that does both the Ctrl+click operation and the Shift+click operation, allowing ranges of contiguous and non-contiguous clips to be added/removed from the selection. It's probably easier to understand with an example. Visit https://htmledit.squarefree.com/ then paste the following:
<select multiple="true" size="10">
<option>first</option>
<option>second</option>
<option>third</option>
<option>fourth</option>
<option>fifth</option>
<option>sixth</option>
<option>seventh</option>
<option>eighth</option>
<option>ninth</option>
<option>tenth</option>
</select>Play around with clicks, Ctrl+clicks, Shift+clicks, and Ctrl+Shift clicks. Having that modifier behaviour in OpenShot would be consistent and useful. At present, the Shift modifier key does nothing.
On that same note, usually Ctrl+a performs a "Select All" action. If users could somehow select a track (maybe click the track name?) then press Ctrl+a to select all clips, that'd be helpful.
Note: For some reason I had written about Boolean modifiers. I really mean Set modifiers (i.e., the Set of clips to be modified).
ghost
commented
1 year ago Re: https://trello.com/c/6LzSZtm2/113-export-screen-process-enhancements
That ticket contains a few separate ideas that could probably be split out:
untitled.mp4, not Untitled.mp4; prefer to use lowercase)Also, no spaces in file names. Prefer either hyphens or underscores. In NTS, they created a "FileName" interface that represented the name of a file. All other API calls that used files would take a FileName instance. This allows for application-wide enforcement of standard file name naming conventions. (It also solves relative pathing issues because you must create new FileName instances from an existing instance, and there's only allowed one "root" instance.)
Colorjet3
commented
1 year ago Hell @DaveJarvis Thank you again for all your comments and feedback to improve Openshot.
I am unable to replicate the Arch Linux issue but went ahead and created a Trello card: https://trello.com/c/hmxZdYKY/117-on-arch-linux-when-openshot-starts-it-displays-and-audio-error-message
Key Markers are skipped when too close. I was able to replicate this once I realized how much I needed to zoom into the timeline. Trello card created: https://trello.com/c/GujC8VGs/118-key-markers-are-skipped-when-they-are-close-together
CTRL and SHIFT operations don't quite work like boolean operators. Trello card created: https://trello.com/c/W21uf79l/120-the-ctrl-and-shift-operations-dont-quite-work-like-boolean-operators-from-other-windows-programs
The Export screen options, I will let the lead developer review and decide how to move forward. I will add your comments to the Trello card I created.
I believe I have captured all of your suggested bugs and enhancements.
Update: During the Marker being skipped testing and came across another issue and captured it here: https://trello.com/c/nY85spEp/122-the-playhead-isnt-aligned-properly-with-the-end-of-a-clip-when-you-zoom-in
This ticket lists technical and workflow issues I encountered while using OpenShot 3.0.0, on Arch Linux.
Replicate
Expected
Application opens.
Actual
Application opens with an error:
Aside, the error message is grammatically incorrect, there's a
:missing; also, the error message gives no indication as to what the actual problem is nor how to resolve it. Further, this error doesn't appear to affect the application, so restarting the software doesn't appear to be necessary (but maybe it's because I'm not using any sound).Continue:
Expected
The open file dialog shows files in the application's working directory (i.e., the directory from which the application was launched, such as a "videos" directory).
Actual
The file dialog shows files in the user's home directory, forcing the user to navigate to the same video directory twice (once in a terminal before launching the app, and once in the dialog).
Expected
Files of type defaults to video files, image files, project data files, and other acceptable imports.
Actual
All files are listed in the import file dialog, including
OpenShot-v3.0.0-daily-10873-99aab0a1-f55ec5d0-x86_64.AppImage.Continue:
Expected
A context menu appears (or a tooltip indicating what the user needs to do to perform an action at the play-head position), allowing the user to slice. In other words, always have some affordance instructing the user what needs to happen. For example, if I've activated the cut tool (Scissors icon), then a right-click would have a message stating, "Disable cut mode before slicing." Or some such. (It isn't immediately apparent how to bring up the context menu when the context menu doesn't display...)
Actual
Nothing appears.
Work around
Click one of the other main icons (scissors, magnet, key frame) before displaying the play-head context menu.
Continue:
Expected
The Scissors icon noticeably changes to indicate the functionality is enabled.
Actual
Folks having poor eyesight and large monitors will be hard-pressed to see the difference between enabled and disabled. Here's disabled:
Here's enabled:
Consider increasing the contrast (or adding a small round "indicator dot") so that the mode is easier to spot.
With the scissor tool enabled, continue:
Expected
The cut tool is able to cut at that point.
Actual
The cut tool disappears. Here's where the mouse is very close to the ruler:
Here's where the mouse is hovering over the ruler:
While the scissors tool is enabled and the mouse is hovering over the ruler:
Expected
A cut is made at the ruler.
Actual
Nothing happens.
Work around
Move the mouse to the left or right of the ruler and make a cut. Ideally, the software would pick a point very close to the ruler and make the cut anyway. If there's a mathy reason why the software can't cut exactly at the ruler, perhaps add a very slight offset to solve the mathy problem?
Continue without cutting:
Expected
Dragging still scrubs through the video.
Actual
Scrubbing stops. This is awkward because, on a big screen (4K UHD, 42 inches), I'm not able to visually track the mouse and watch the video at the same time. Consequently, the mouse moves above/below the Play-Head timeline area, causing scrubbing to stop. I have to look away from the video playback and readjust the mouse, which breaks workflow.
Sample screenshot (not at maximum window size, but big enough to get the idea across):
With the mouse back along the timeline, continue:
Expected
The timeline zoom in and out.
Actual
Nothing happens. It seems zooming only works when the mouse is over a track. I'd have expected zooming to work when the mouse cursor is hovering over the Play-Head's timeline region as well. This goes for panning using Shift, too!
Continue:
Actual
There's no option to eliminate the gap, resulting in:
Expected
An option exists to slice and shift the entire timeline to eliminate the gap, resulting in:
This is a kind of syntactic sugar because I do both of these operations a lot.
Continue:
Expected
untitled.mp4.Actual
Copy text Untitled ProjectContinue:
untitled.mp4Web.YouTube HD.Med(note: this should be Medium, unless you fear typing)Expected
After the export completes, the user can change the settings and export again.
Actual
All the buttons go away:
The user is forced to dismiss the dialog, and re-open it, as though OpenShot is passive-aggressively wanting to suck your life away by making you jump through hoops that seem completely unnecessary. ;-)
Leave the dialog enabled and change up the buttons after export completes:
Consider adding a checkbox that allows overwriting an existing file, as well, so that the workflow isn't interrupted with a prompt to confirm overwriting all the time.
Continue:
Expected
The program saves the project then terminates. (Since the dawn of C, computer programs have honoured the line control message of "end of text" to mean "terminate the program".)
Actual
The program doesn't terminate.
Feature Request
When hovering over the Prev/Next Key Point buttons, include the relative amount of time to the previous or next key point (depending on which button the mouse is hovering over).
In the screnshot, it would be nice to know how much time has passed between the Play-Head and the previous key point. This is useful, for example, when cropping out sections of video but you still want to inform viewers how much time elapsed.
In the screenshot, the tooltip would include "66 seconds" (being roughly 3 minutes 8 seconds - 2 minutes and 2 seconds).
Feature Request
Add the Redo/Undo action name to the Edit menu so that users can see what action is about to be redone/undone prior to electing to perform the action.
Feature Request
Use lowercase for all default file names on Unix platforms, such as Linux and macOS. For example, when exporting a screenshot, prefer the name
frame-0001.pngtoFrame-0001.png(it's just easier for typing from the command-line).Feature Request
After taking a screenshot of the current frame, ask the user whether they'd like to save the frame into the same directory as the video currently being edited and import the frame into the project files. Consider adding a checkbox to "remember the decision" so that screenshots are always added into the project automatically.
Feature Request
Try this:
The clips should stay selected, rather than be deselected. This would make it easier to add more clips to the currently selected clips with additional Ctrl-clicks. From there, users could continue squeezing the gaps.
Of course, even better would be an option to select all the clips and automatically remove the gaps. Nonetheless, if you think about the user as having entered data by "selecting clips" then that data is lost after the drag operation is finished. Never lose user data. (When I want to deselect all clips I will deliberately single-click elsewhere without holding down any modifier keys. Modifier keys are meant to modify operations, such as revising the currently selected set of objects.)
Enhancement Request
Consider revising the docker UI to include affordances that are a bit more obvious on large monitors, such as:
Enhancement Request
After dropping an image onto a timeline, I'd like to expand the size of the image along the timeline by dragging on either the left-hand or right-hand side of the image. Try this:
At present, the image can only be changed from the right-hand side, which means moving the image to the left, which is a separate conceptual operation. In effect, if I can increase the image time by dragging on the right-hand side, I should be able to do the same on the left-hand side.
Bug
When key markers are close together, the Next/Prev key marker buttons will skip the marker. Before clicking Next:
After clicking Next:
Bug
After exporting a video to a file, the file name resets. In the following export screen, note that the file
/tmp/video.mp4does not exist:After clicking Export Video, I am surprised to be prompted to overwrite a file that did not exist (this is a bug; upon entering the File Name value, it seems a 0-byte file is created without necessity):
Upon completion, the dialog shows:
Click Done then press Ctrl+E again. (Seriously, please change this. Don't force closing the dialog, it's so annoying.) The settings have reset:
All the settings have been lost, which violates the number one rule of software development: don't lose your user's data. (On that note, consider saving the project automatically before an export takes place. OpenShot used to have countless crashing issues that resulted in data loss.)