OpenShot / openshot-qt

OpenShot Video Editor is an award-winning free and open-source video editor for Linux, Mac, and Windows, and is dedicated to delivering high quality video editing and animation solutions to the world.
http://www.openshot.org
Other
4.27k stars 532 forks source link

On RightClick, select the clip below the cursor if any #5459

Open f-michaut opened 7 months ago

f-michaut commented 7 months ago

Not sure if this should be a bug report instead, but I'm assuming the current behavior is WAI.

Describe the new feature: When right-clicking on a clip, I would expect to select just that clip - like when you right click a file in a FileExplorer app -> if you select an already selected file, it keeps the current selection and opens the menu for the selection; If you select an unselected file it clears the selection and create a new one with just that file and open the menu for that file only.

The current behavior is very different, in the sense that it does not change the selection. Let's say I have a bunch of clips, and i've been doing some moving around + slicing. I drag my last clip properly in place (it is now selected). I have a few leftover clips that I am not gonna use, so I move my mouse on top of it and hit RightClick, opening the menu and select Remove Clip. Currently this results in the previously selected clip (the one I wanted to keep) to be deleted and not the one I just right-clicked.

Describe the solution you'd like: If that is an expected feature that people like and want, provide a setting to change the clip right-clicked behavior. Although, I do feel like the new behavior would be more natural for most users.

Describe alternatives you have considered: I can left-click and then right click, but that's one more click. Or I can hit Delete on my keyboard, but since I'm already using my mouse while working on a video, that key is far from both my hands.

raindropsfromsky commented 6 months ago

I'd describe this behavior as "eat the first right-click". Or, force a left click first to select new object(s) and only then do something on it/them.

That preserves the existing selection, and I personally I like it.

It's a choice between-

Colorjet3 commented 6 months ago

I've been thinking about this one for a long time now. Another example I can provide which I run into often is this:

  1. Drag two clips onto a track.
  2. Select one of them so it has the red border around it.
  3. Now drag an effect on the other clip (which is not selected) from the Effects tab.
  4. Note that the other clips has the effect but is not selected, which doesn't make sense. I expect the focus now to be on this other clip with the effect on it.
  5. Additionally, I think the Properties windows for the Effect itself should open up. This is in anticipation that I will be making some adjustments to the Effect itself.

To me, it gets confusing if Clip 1 is selected, and then right click on Clip 2, select Properties or add animation while Clip 1 has the red border line on it.

What are your thoughts also about jumping the Playhead to the beginning of that clip that you Right Click on? Does this idea have merits?

I don't think on a left click the Playhead should jump to that clip.

raindropsfromsky commented 6 months ago

I totally like this idea!

In fact, the fact that the effect was dropped on the unselected clip undoubtedly means that you want to work with that clip now. In other words, your interest on the hitherto selected clip is already over.

Therefore, Openshop should intelligently move the focus on the clip on which the effect was dropped. 👍

The "jump the playhead to the beginning of that clip" and "opening the properties panel for the effect" are also intelligent moves, because Openshot anticipates that the user will now make fine adjustments to the effect, which may include creating keyframes (which is why the playhead needs to be parked at the beginning of the target clip: If the same effect is applied to the whole clip, the position of the playhead is immaterial).