OpenShot / openshot-qt

OpenShot Video Editor is an award-winning free and open-source video editor for Linux, Mac, and Windows, and is dedicated to delivering high quality video editing and animation solutions to the world.
http://www.openshot.org
Other
4.26k stars 532 forks source link

Volume Keyframe Constant type not working properly #5491

Open leodf1 opened 5 months ago

leodf1 commented 5 months ago

Describe the bug: The 'Constant' type keyframe for the Volume property does not affect the adjustment instantly, but has a two/four frame tail/fade to the desired level.

Steps to reproduce the behavior: 1.Set a Volume keyframe in the Properties of an audio track, to zero or a lower volume

  1. Set the keyframe type to Constant
  2. Carefully playback the audio track
  3. Notice the audio fades down to the desired level over two frames past the keyframe, instead of setting the level exactly at the keyframe

Expected behavior: Volume should be set to the desired level exactly at the keyframe point when using the 'Constant' type

System Details:

leodf1 commented 5 months ago

Keyframe does not affect the level change instantly at the keyframe point, but instead acts as a short Linear change over two frames past the point. Makes it hard to remove noises etc from the audio track without precise control over the Volume keyframes.

[480P 15FPS PROFILE USED. So might happen across four frames on a 30fps profile, I don't know]

Not sure if this only affects the Volume Property or other Property keyframes too.

Had not noticed this in earlier version, so bug may have been introduced in this version of the software.

tldr: Constant type keyframe acts as a Linear type keyframe

Colorjet3 commented 2 months ago

Hello @leodf1. I haven't seen a reply on this. I tried to replicate your issue without success.

Here are the steps I did to try and replicate the issues:

  1. Imported a .mp4 file that has audio from the beginning and dragged it unto Track 5 position at 0:00.
  2. Positioned the playhead with the left edge of the clip. This is important so you don't get animation.
  3. Right Click | Properties | Volume attribute and changed it from 1.00 to 0.00.
  4. Previewed the clip and no volume for the entire clip.
  5. Re-positioned the playhead at the left edge of the clip.
  6. Modified the Volume from 0.00 to 0.5.
  7. Previewed the clip and the volume is lower now for the entire clip.

If you are doing something different then be very clear in your step-by-step instructions so we can follow it precisely.