search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
269 stars 124 forks source link

Index in the road markings is missing #237

Open mbencik999 opened 6 years ago

mbencik999 commented 6 years ago

In the road marking class the enum RoadMarking_Classification_Color is missing the index 4. This is very troublesome for the test procedures since a random number from 0 - 7 does not cover all the cases and the range is wrong. It would be very nice if someone could take a look at this.

pmai commented 6 years ago

This seems to be a hold-over from the initial OSI commit, which already did not contain a color with index 4. We should likely fix this at some time; for OSI 3.x we can only fix this by adding a new color with index 4 (maybe a relevant color is still missing?), renumbering would only be possible with 4.x.

Can someone check this with relevant users?

ghost commented 6 years ago

As this issue is about an enhancement, and since no one responded by now, I will postpone it to OSI 3.1.0.

carsten-kuebler commented 6 years ago

@LudwigFriedmannBMW As Pierre points out, a re-sort leads to a major version change (4.x). Adding a new color could close the gap (3.1.x). Should we disallow missing elements in enums (e.g. by a test)? This would be different from numbering of the attributes in the messages.