search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
269 stars 126 forks source link

TrafficSign::MainSign::Classification::value is not represent #272

Open cszyszka opened 6 years ago

cszyszka commented 6 years ago

Issue

In some cases we might need to represent multiple TrafficSignValue in TrafficSign This occurs in case there are multiple physical values on one TrafficSign.

My suggestion would be to change TrafficSign::MainSign::Classification::value to repeated field type. TheTrafficSign::SupplementarySign::Classification::value is already repeated.

Examples

Vertical clearance

OSI can not represent foots and inches Vertical clearance

In addition to foots and inches we also have metric system. Double Vertical clearance

Speed limit

Image 3

Maybe this situation can be handled with multiple supplementary signs? Sepeed Limit Germany Boarder

ghost commented 6 years ago

Hi @cszyszka, at least the unit feet is already present (besides the metric units) in the "Unit" enum in TrafficSignValue. Inches may be added,

In #258, consolidated signs like Stvo 393 are added to the trafficsign.proto.

Nevertheless, as you proposed, a repeated value entry might be required for some of the above signs,

ghost commented 5 years ago

Changing the field from "optional" to "repeated" would be a mojor version change. But the PR #258 did solve the problem partially. I will keep this issue and postpone the milestone to 4.0.0.