search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
267 stars 125 forks source link

Introducing Operating States #624

Closed ThomasNaderBMW closed 2 years ago

ThomasNaderBMW commented 2 years ago

The operating state of the vehicle.

Signed-off-by: Thomas Nader Thomas.Nader@bmw.de

Add a description

Beyond sheer driving use cases, this extension is needed to show if a vehicle is actually operating or not. It is an overall state that may turn off or on the electrical consumers in the vehicle.

Some questions to ask: What is this change? An improvement. What does it fix? No bug fix. Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version? It is a feature, no break. How has it been tested? With a similar signal on a HiL(dynamic+RBS) and a mockup.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why. If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

ThomasNaderBMW commented 2 years ago

@caspar-ai , thank you for the review! Creating this PR, I was also unsecure in naming and sorting in. So feedback from the CCB additionally to yours may be helpful here.

kmeids commented 2 years ago

Output CCB 25.04.2022

  1. Extend the enums under "OperatingStatus"
  2. Consider updating the name of the _optional OperatingStatus operatingstatus = 2; as suggested in https://github.com/OpenSimulationInterface/open-simulation-interface/pull/624/files#r849606740
ThomasNaderBMW commented 2 years ago

CCB: Can be merged.

ThomasNaderBMW commented 2 years ago

CCB: Can be merged.