search

OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
265 stars 124 forks source link

ISO23150 compliance: Adding new states to [StationaryObject – Classification - Type] #641

Open FlorianMueller87 opened 2 years ago

FlorianMueller87 commented 2 years ago

Describe the feature

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_objects – StationaryObject – Classification - Type to be compatible with AUTOSAR ADI GeneralLandmarkClassificationType.

Describe the solution you would like

Add in osi_objects – StationaryObject – Classification - Type the following entries:

// // TYPE_ BARREL = 17;

// // TYPE_ GUIDE_POST = 18;

// // TYPE_ TUNNEL = 19;

Describe alternatives you have considered

No alternative was considered.

Describe the backwards compatibility

The adding of the elements will not lead to backward compatibility issues.

Additional context

ISO23150:2021 A.2.105 General landmark classification type

@ThomasNaderBMW @jdsika @schmidtlorenz

pmai commented 2 years ago

I'm a bit confused why TYPE_VERTICAL_STRUCTURE and TYPE_RECTANGULAR_STRUCTURE occur in this list, since they are verbatim already part of OSI's definition.

Similarly TYPE_LAMP_POST, TYPE_OVERHEAD_OBJECT, TYPE_REFLECTOR, and TYPE_BEACON are already present as TYPE_POLE, TYPE_OVERHEAD_STRUCTURE, TYPE_REFLECTIVE_STRUCTURE, and TYPE_CONSTRUCTION_SITE_ELEMENT.

TYPE_TUNNEL and TYPE_GUIDE_POST might be additions, though I seem to remember discussions to handle them differently...

TYPE_BARREL seems a fairly clear addition.

FlorianMueller87 commented 2 years ago

Thats correct, I will change this.