OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
265 stars 124 forks source link

ISO23150 compliance: Adding new element to [ColorDescription] #647

Open FlorianMueller87 opened 2 years ago

FlorianMueller87 commented 2 years ago

Describe the feature

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality. ASAM OSI need the entries for osi_common - ColorDescription to be compatible with AUTOSAR ADI ColourClassificationType.

Describe the solution you would like

Add in osi_common - ColorDescription the following element:

optional ColorList list = 7;

With:

message ColorList
{
    optional List = 1;
    enum List
    {
        // Color is unknown (must not be used in ground truth).
            //
            COLOR_UNKNOWN = 0;

            // Other (unspecified but known) color.
            //
            COLOR_OTHER = 1;

            // Yellow.
            //
            COLOR_YELLOW = 2;

            // Green.
            //
            COLOR_GREEN = 3;

            // Blue.
            //
            COLOR_BLUE = 4;

            // Violet.
            //
            COLOR_VIOLET = 5;

            // Red.
            //
           COLOR_RED = 6;

            // Orange.
            //
            COLOR_ORANGE = 7;

            // Black.
            //
            COLOR_BLACK = 8;

            // GREY.
            //
            COLOR_GREY = 9;

            // White.
            //
            COLOR_WHITE = 10;
        }
 }

Describe alternatives you have considered

No alternative was considered.

Describe the backwards compatibility

The adding of the elements will not lead to backward compatibility issues.

Additional context

ISO23150:2021 A.1.15 Colour model type @ThomasNaderBMW @jdsika @schmidtlorenz

jdsika commented 1 year ago

For what are those colors used? The color enums will be deprecated in OSI with v4.0.0 and replaced by this defintion - example:

◆ Color

enum osi3::CameraDetection::Color --

Definition of shape dominant color.

Attention
DEPRECATED: This color enum will be removed in version 4.0.0. Use ColorDescription instead.
FlorianMueller87 commented 1 year ago

It looks like it will not used anywhere. I will bring this up with ISO.

FlorianMueller87 commented 1 year ago

At the moment, ISO as well as ADI did not use ColorList. It was implemented for future issues. If you not see any usage for it, I can live with rejecting this issue for the moment.

jdsika commented 1 year ago

Comment:

jdsika commented 1 year ago

Could you check the color model with ISO23150 please? @carsten-kuebler