OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
267 stars 125 forks source link

Add new enum Type in vehicle classification for stand-up scooters #676

Closed schmidtlorenz closed 1 year ago

schmidtlorenz commented 1 year ago

feat(vehicle classifications): add classification for stand-up scooters, motivated by possible NCAP target type

#### Reference to a related issue in the repository refers to issue #673

Add a description

This adds a new enum Type in vehicle classification for stand-up or kickboard scooters.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

jdsika commented 1 year ago

Please fix build in order to hand this over to the CCB. Can you add the reference to a relevant NCAP document? Maybe even in the description. I think most descriptions would benefit from a little more verbose comments.

ThomasNaderBMW commented 1 year ago

Jobs are failing because of this: osi_object.proto:871:36: "osi3.MovingObject.VehicleClassification.TYPE_STANDUP_SCOOTER" uses the same enum value as "osi3.MovingObject.VehicleClassification.TYPE_SEMITRACTOR". If this is intended, set 'option allow_alias = true;' to the enum definition.

So Semitractor has already ID 16, you can take 17 e.g. @schmidtlorenz

schmidtlorenz commented 1 year ago

I removed the links since I could not find persistent versions (e.g. PURL or DOI).