OpenSimulationInterface / open-simulation-interface

A generic interface for the environmental perception of automated driving functions in virtual scenarios.
Other
273 stars 127 forks source link

Fix image_data comment on pixel order #684

Closed thomassedlmayer closed 1 year ago

thomassedlmayer commented 2 years ago

Description

We noticed that the pixel order of the image_data field in CameraSensorView was not specified by CameraSensorViewConfiguration as the description of image_data says:

The raw image data in the memory layout and order specified by the camera sensor input configuration.

Since both radar and lidar reflections are currently defined to be ordered left-to-right, top-to-bottom (see following quote), it could be the case that this was accidently omitted for image_data. (RadarSensorView, LidarSensorView)

This field includes one entry for each ray, in left-to-right, top-to-bottom order (think of scan lines in a TV).

Therefore, the default pixel order should probably align with the definitions of radar and lider reflections. If further pixel orders are desired a enum could be added to CameraSensorViewConfiguration but I think this small change would already clarify enough to be able to reliably exchange image data with OSI.

This change can be seen as a bug fix. The description of image_data that a pixel order can be specified in CameraSensorViewConfiguration is definitely misleading.

Checklist

#### References

681

pmai commented 2 years ago

CCB 2022-11-07: Still to be discussed in sensor group, hence postponed at CCB.

jdsika commented 1 year ago

replaced by #698